Make IntRange explicitly inclusive to [min, max]. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a length bug with StringRange as well where generated strings were no more than max-1 characters long (instead of being no more than max characters long as described).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not entirely clear, but it looks like
IntRangewas meant to be fully inclusive to the range[min, max]. Before this change, it was exclusive tomax, i.e. the range was[min, max).This change makes
IntRangefully inclusive. This also fixes a bug inStringRangethat was only generating strings up tomax - 1length (instead of generating strings up tomaxlength as per its comment).With this fix, the
max == mincase is handled automatically, so noswitchis required. I also had to adjust the other utility functions to take into account the inclusivemax.If
IntRangewas meant to be[min, max)only, feel free to reject this PR, but I'd then recommend fixingStringRangeand making it clear thatIntRangeexcludesmax.